From 69bce376b09d4aed395865223c31b128ef4d8521 Mon Sep 17 00:00:00 2001 From: Jan Schmidt Date: Thu, 8 Oct 2009 02:03:08 +0100 Subject: [PATCH] plugin: Ignore an empty dependency list. If a plugin registers an empty dependency set, just ignore it rather than serialising and checking an empty set. --- gst/gstplugin.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/gst/gstplugin.c b/gst/gstplugin.c index 5e2131d2b0..dc00720709 100644 --- a/gst/gstplugin.c +++ b/gst/gstplugin.c @@ -1605,7 +1605,13 @@ gst_plugin_add_dependency (GstPlugin * plugin, const gchar ** env_vars, GList *l; g_return_if_fail (GST_IS_PLUGIN (plugin)); - g_return_if_fail (env_vars != NULL || paths != NULL); + + if ((env_vars == NULL || env_vars[0] == NULL) && + (paths == NULL || paths[0] == NULL)) { + GST_DEBUG_OBJECT (plugin, + "plugin registered empty dependency set. Ignoring"); + return; + } for (l = plugin->priv->deps; l != NULL; l = l->next) { if (gst_plugin_ext_dep_equals (l->data, env_vars, paths, names, flags)) {