From 676b371bdb2d80e9beee9c527b92c46214af4550 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Sat, 25 Feb 2012 15:55:15 +0000 Subject: [PATCH] qtmux: create streamable output if downstream is not seekable Ignore the "streamable" property setting and create streamable output if downstream is known not to be seekable (as queried via a SEEKABLE query). Fixes pipelines like qtmux ! appsink possibly creating seemingly corrupted output if streamable has not been set to true. --- gst/isomp4/gstqtmux.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/gst/isomp4/gstqtmux.c b/gst/isomp4/gstqtmux.c index 2ce98400b3..80fa5afbe4 100644 --- a/gst/isomp4/gstqtmux.c +++ b/gst/isomp4/gstqtmux.c @@ -1613,6 +1613,30 @@ gst_qt_mux_start_file (GstQTMux * qtmux) gst_pad_set_caps (qtmux->srcpad, caps); gst_caps_unref (caps); + /* if not streaming, check if downstream is seekable */ + if (!qtmux->streamable) { + gboolean seekable; + GstQuery *query; + + query = gst_query_new_seeking (GST_FORMAT_BYTES); + if (gst_pad_peer_query (qtmux->srcpad, query)) { + gst_query_parse_seeking (query, NULL, &seekable, NULL, NULL); + GST_INFO_OBJECT (qtmux, "downstream is %sseekable", + seekable ? "" : "not "); + if (!seekable) { + qtmux->streamable = TRUE; + g_object_notify (G_OBJECT (qtmux), "streamable"); + GST_WARNING_OBJECT (qtmux, "downstream is not seekable, but " + "streamable=false. Will ignore that and create streamable output " + "instead"); + } + } else { + /* have to assume seeking is supported if query not handled downstream */ + /* FIXME 0.11: change to query not handled => seeking not supported */ + GST_WARNING_OBJECT (qtmux, "downstream did not handle seeking query"); + } + } + /* let downstream know we think in BYTES and expect to do seeking later on */ gst_pad_push_event (qtmux->srcpad, gst_event_new_new_segment (FALSE, 1.0, GST_FORMAT_BYTES, 0, -1, 0));