From 66351255f7491a066ac69c49bf6f3bff6d35cd88 Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Wed, 22 Aug 2018 19:23:53 +0000 Subject: [PATCH] v4l2object: Only offer MMAP/DMABUF pool The propose allocation was offering a pool even in DMABUF_IMPORT or USERPTR mode. These pool are internal only. --- sys/v4l2/gstv4l2object.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/sys/v4l2/gstv4l2object.c b/sys/v4l2/gstv4l2object.c index 9b50c16a64..e9b3e24f1c 100644 --- a/sys/v4l2/gstv4l2object.c +++ b/sys/v4l2/gstv4l2object.c @@ -4555,8 +4555,16 @@ gst_v4l2_object_propose_allocation (GstV4l2Object * obj, GstQuery * query) if (caps == NULL) goto no_caps; - if ((pool = obj->pool)) - gst_object_ref (pool); + switch (obj->mode) { + case GST_V4L2_IO_MMAP: + case GST_V4L2_IO_DMABUF: + if ((pool = obj->pool)) + gst_object_ref (pool); + break; + default: + pool = NULL; + break; + } if (pool != NULL) { GstCaps *pcaps;