From 662a674f8a33547cd90dd79aa1557385567930f7 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Tue, 16 Dec 2014 12:57:55 +0100 Subject: [PATCH] ximagesink: clear src and dest rectangles Now that the center function also takes into account the x and y coordinates of the dest rectangle, better clear all the fields before using them. --- sys/ximage/ximagesink.c | 4 +++- sys/xvimage/xvimagesink.c | 7 +++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/sys/ximage/ximagesink.c b/sys/ximage/ximagesink.c index ff6a9d60bc..2a1f76b3af 100644 --- a/sys/ximage/ximagesink.c +++ b/sys/ximage/ximagesink.c @@ -230,7 +230,9 @@ gst_ximagesink_ximage_put (GstXImageSink * ximagesink, GstBuffer * ximage) { GstXImageMemory *mem; GstVideoCropMeta *crop; - GstVideoRectangle src, dst, result; + GstVideoRectangle src = { 0, }; + GstVideoRectangle dst = { 0, }; + GstVideoRectangle result; gboolean draw_border = FALSE; /* We take the flow_lock. If expose is in there we don't want to run diff --git a/sys/xvimage/xvimagesink.c b/sys/xvimage/xvimagesink.c index 6bd5b3e257..a0d62a06db 100644 --- a/sys/xvimage/xvimagesink.c +++ b/sys/xvimage/xvimagesink.c @@ -229,7 +229,8 @@ gst_xvimagesink_xvimage_put (GstXvImageSink * xvimagesink, GstBuffer * xvimage) GstVideoCropMeta *crop; GstVideoRectangle result; gboolean draw_border = FALSE; - GstVideoRectangle src, dst; + GstVideoRectangle src = { 0, }; + GstVideoRectangle dst = { 0, }; GstVideoRectangle mem_crop; GstXWindow *xwindow; @@ -1129,7 +1130,9 @@ gst_xvimagesink_navigation_send_event (GstNavigation * navigation, if ((peer = gst_pad_get_peer (GST_VIDEO_SINK_PAD (xvimagesink)))) { GstEvent *event; - GstVideoRectangle src, dst, result; + GstVideoRectangle src = { 0, }; + GstVideoRectangle dst = { 0, }; + GstVideoRectangle result; gdouble x, y, xscale = 1.0, yscale = 1.0; GstXWindow *xwindow;