From 65f935480360a55f8d1ec5211812c1e921d86666 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20Stadler?= Date: Sun, 16 Oct 2011 20:05:28 +0200 Subject: [PATCH] pngenc: ensure setcaps was called before chain function This is needed to properly error out for e.g. "fakesrc ! pngenc ! fakesink". --- ext/libpng/gstpngenc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ext/libpng/gstpngenc.c b/ext/libpng/gstpngenc.c index e59da9be08..7bad0377bd 100644 --- a/ext/libpng/gstpngenc.c +++ b/ext/libpng/gstpngenc.c @@ -271,6 +271,11 @@ gst_pngenc_chain (GstPad * pad, GstBuffer * buf) GST_DEBUG_OBJECT (pngenc, "BEGINNING"); + if (G_UNLIKELY (pngenc->width <= 0 || pngenc->height <= 0)) { + ret = GST_FLOW_NOT_NEGOTIATED; + goto done; + } + if (G_UNLIKELY (GST_BUFFER_SIZE (buf) < pngenc->height * pngenc->stride)) { gst_buffer_unref (buf); GST_ELEMENT_ERROR (pngenc, STREAM, FORMAT, (NULL),