mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-30 13:41:48 +00:00
Code Issues 1 Projects Releases Wiki Activity

isomp4: Fix coverity warning

Browse source 
If atom_copy_data fails to write anything, return 0

CID #1371458
This commit is contained in:
Vivia Nikolaidou 2016-08-19 17:18:16 +03:00 committed by Sebastian Dröge
parent 4048a4e137
commit 64fd099a3a
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gst/isomp4/atoms.c
View file

@ -2115,7 +2115,8 @@ sample_entry_tx3g_copy_data (SampleTableEntryTX3G * tx3g, guint8 ** buffer,
Atom atom; Atom atom;
atom_header_set (&atom, FOURCC_ftab, 18, 0); atom_header_set (&atom, FOURCC_ftab, 18, 0);
atom_copy_data (&atom, buffer, size, offset); if (!atom_copy_data (&atom, buffer, size, offset))
return 0;
prop_copy_uint16 (1, buffer, size, offset); /* Count must be 1 */ prop_copy_uint16 (1, buffer, size, offset); /* Count must be 1 */
prop_copy_uint16 (1, buffer, size, offset); /* Font id: 1 */ prop_copy_uint16 (1, buffer, size, offset); /* Font id: 1 */
prop_copy_size_string ((guint8 *) "Serif", 5, buffer, size, offset); prop_copy_size_string ((guint8 *) "Serif", 5, buffer, size, offset);
@ -2150,7 +2151,8 @@ sample_entry_tmcd_copy_data (SampleTableEntryTMCD * tmcd, guint8 ** buffer,
guint64 name_offset = *offset; guint64 name_offset = *offset;
atom_header_set (&atom, FOURCC_name, 0, 0); atom_header_set (&atom, FOURCC_name, 0, 0);
atom_copy_data (&atom, buffer, size, offset); if (!atom_copy_data (&atom, buffer, size, offset))
return 0;
prop_copy_uint16 (strlen (tmcd->name.name), buffer, size, offset); prop_copy_uint16 (strlen (tmcd->name.name), buffer, size, offset);
prop_copy_uint16 (tmcd->name.language_code, buffer, size, offset); prop_copy_uint16 (tmcd->name.language_code, buffer, size, offset);
prop_copy_fixed_size_string ((guint8 *) tmcd->name.name, prop_copy_fixed_size_string ((guint8 *) tmcd->name.name,