From 64e84407bd700cac2a0a46bc4911256afa10587b Mon Sep 17 00:00:00 2001
From: Thibault Saunier <tsaunier@igalia.com>
Date: Sat, 14 Jul 2018 08:27:05 -0400
Subject: [PATCH] validate:scenario: Add a way to set rank on all features of a
 plugin

You often want to make sure that elements from a particular plugins
are always/never plugged, `set-rank,name=plugin-name,rank=XXX` allows
you to simply do that.
---
 validate/gst/validate/gst-validate-scenario.c | 53 +++++++++++++++----
 1 file changed, 43 insertions(+), 10 deletions(-)

diff --git a/validate/gst/validate/gst-validate-scenario.c b/validate/gst/validate/gst-validate-scenario.c
index 8a792989eb..fab2c48c86 100644
--- a/validate/gst/validate/gst-validate-scenario.c
+++ b/validate/gst/validate/gst-validate-scenario.c
@@ -1375,32 +1375,46 @@ static GstValidateExecuteActionReturn
 _execute_set_rank (GstValidateScenario * scenario, GstValidateAction * action)
 {
   guint rank;
+  GList *features, *origlist;
+  GstPlugin *plugin;
   GstPluginFeature *feature;
-  const gchar *feature_name;
+  const gchar *name;
 
-  if (!(feature_name =
-          gst_structure_get_string (action->structure, "feature-name"))) {
-    GST_ERROR ("Could not find the name of the feature to tweak");
+  if (!(name = gst_structure_get_string (action->structure, "feature-name")) &&
+      !(name = gst_structure_get_string (action->structure, "name"))) {
+    GST_ERROR ("Could not find the name of the plugin feature(s) to tweak");
 
     return GST_VALIDATE_EXECUTE_ACTION_ERROR;
   }
 
   if (!(gst_structure_get_uint (action->structure, "rank", &rank) ||
           gst_structure_get_int (action->structure, "rank", (gint *) & rank))) {
-    GST_ERROR ("Could not get rank to set on %s", feature_name);
+    GST_ERROR ("Could not get rank to set on %s", name);
 
     return GST_VALIDATE_EXECUTE_ACTION_ERROR;
   }
 
-  feature = gst_registry_lookup_feature (gst_registry_get (), feature_name);
-  if (!feature) {
-    GST_ERROR ("Could not find feature %s", feature_name);
+  feature = gst_registry_lookup_feature (gst_registry_get (), name);
+  if (feature) {
+    gst_plugin_feature_set_rank (feature, rank);
+    gst_object_unref (feature);
+
+    return GST_VALIDATE_EXECUTE_ACTION_OK;
+  }
+
+  plugin = gst_registry_find_plugin (gst_registry_get (), name);
+  if (!plugin) {
+    GST_ERROR ("Could not find %s", name);
 
     return GST_VALIDATE_EXECUTE_ACTION_ERROR;
   }
 
-  gst_plugin_feature_set_rank (feature, rank);
-  gst_object_unref (feature);
+  origlist = features =
+      gst_registry_get_feature_list_by_plugin (gst_registry_get (),
+      gst_plugin_get_name (plugin));
+  for (; features; features = features->next)
+    gst_plugin_feature_set_rank (features->data, rank);
+  gst_plugin_feature_list_free (origlist);
 
   return GST_VALIDATE_EXECUTE_ACTION_OK;
 }
@@ -4130,6 +4144,25 @@ init_scenarios (void)
       "Note that the GST_DEBUG_DUMP_DOT_DIR env variable needs to be set",
       GST_VALIDATE_ACTION_TYPE_NONE);
 
+  REGISTER_ACTION_TYPE ("set-rank", _execute_set_rank,
+      ((GstValidateActionParameter []) {
+        {
+          .name = "name",
+          .description = "The name of a GstFeature or GstPlugin",
+          .mandatory = TRUE,
+          .types = "string",
+          NULL},
+        {
+          .name = "rank",
+          .description = "The GstRank to set on @name",
+          .mandatory = TRUE,
+          .types = "string, int",
+          NULL},
+        {NULL}
+      }),
+      "Changes the ranking of a particular plugin feature(s)",
+      GST_VALIDATE_ACTION_TYPE_CONFIG);
+
   REGISTER_ACTION_TYPE ("set-feature-rank", _execute_set_rank,
       ((GstValidateActionParameter []) {
         {