From 648c2e20dc42f8240c6594e3961115344b57d52d Mon Sep 17 00:00:00 2001 From: Luis de Bethencourt Date: Mon, 14 Dec 2015 12:31:52 +0000 Subject: [PATCH] glviewconvert: check pointer before dereferencing priv->primary_out could be NULL, check before dereferencing it in GST_BUFFER_FLAG_SET () CID 1308945 --- gst-libs/gst/gl/gstglviewconvert.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/gst-libs/gst/gl/gstglviewconvert.c b/gst-libs/gst/gl/gstglviewconvert.c index 3f36b408c6..9b1e4103c6 100644 --- a/gst-libs/gst/gl/gstglviewconvert.c +++ b/gst-libs/gst/gl/gstglviewconvert.c @@ -2209,11 +2209,13 @@ gst_gl_view_convert_get_output (GstGLViewConvert * viewconvert, } outbuf = priv->primary_out; - gst_buffer_copy_into (outbuf, priv->primary_in, - GST_BUFFER_COPY_FLAGS | GST_BUFFER_COPY_TIMESTAMPS, 0, -1); - GST_BUFFER_FLAG_SET (outbuf, - GST_VIDEO_BUFFER_FLAG_FIRST_IN_BUNDLE | - GST_VIDEO_BUFFER_FLAG_MULTIPLE_VIEW); + if (outbuf) { + gst_buffer_copy_into (outbuf, priv->primary_in, + GST_BUFFER_COPY_FLAGS | GST_BUFFER_COPY_TIMESTAMPS, 0, -1); + GST_BUFFER_FLAG_SET (outbuf, + GST_VIDEO_BUFFER_FLAG_FIRST_IN_BUNDLE | + GST_VIDEO_BUFFER_FLAG_MULTIPLE_VIEW); + } if (priv->auxilliary_out) { gst_buffer_copy_into (priv->auxilliary_out,