From 634eb1fc3866b7eee7956733477deec6e84aa94d Mon Sep 17 00:00:00 2001 From: Seungha Yang Date: Sun, 4 Oct 2020 02:02:16 +0900 Subject: [PATCH] h265parse: Don't enable passthrough by default SEI messages contain various information which wouldn't be conveyed by using upstream CAPS (HDR, timecode for example). Part-of: --- gst/videoparsers/gsth265parse.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gst/videoparsers/gsth265parse.c b/gst/videoparsers/gsth265parse.c index 09706a1ffe..e94f86d24f 100644 --- a/gst/videoparsers/gsth265parse.c +++ b/gst/videoparsers/gsth265parse.c @@ -2978,7 +2978,13 @@ gst_h265_parse_set_caps (GstBaseParse * parse, GstCaps * caps) if (format == h265parse->format && align == h265parse->align) { /* do not set CAPS and passthrough mode if SPS/PPS have not been parsed */ if (h265parse->have_sps && h265parse->have_pps) { + /* Don't enable passthrough here. This element will parse various + * SEI messages which would be very important/useful for downstream + * (HDR, timecode for example) + */ +#if 0 gst_base_parse_set_passthrough (parse, TRUE); +#endif /* we did parse codec-data and might supplement src caps */ gst_h265_parse_update_src_caps (h265parse, caps);