diff --git a/tests/check/nle/complex.c b/tests/check/nle/complex.c index 39ea309f5c..50e04cb761 100644 --- a/tests/check/nle/complex.c +++ b/tests/check/nle/complex.c @@ -57,17 +57,19 @@ fill_pipeline_and_check (GstElement * comp, GList * segments, break; case GST_MESSAGE_ERROR: { - GError *error; + GError *error = NULL; gst_message_parse_error (message, &error, NULL); if (comp == GST_ELEMENT (GST_MESSAGE_SRC (message)) && expected_error_domain == error->domain) { GST_DEBUG ("Expected Error Message from %s : %s", GST_OBJECT_NAME (GST_MESSAGE_SRC (message)), error->message); - carry_on = FALSE; - } else - fail_error_message (message); + } else { + fail_unless (FALSE, "Error Message from %s : %s", + GST_OBJECT_NAME (GST_MESSAGE_SRC (message)), error->message); + } + g_clear_error (&error); } break; default: diff --git a/tests/check/nle/nlecomposition.c b/tests/check/nle/nlecomposition.c index aec78c1aab..eaa9ae5f0b 100644 --- a/tests/check/nle/nlecomposition.c +++ b/tests/check/nle/nlecomposition.c @@ -67,6 +67,7 @@ GST_START_TEST (test_change_object_start_stop_in_current_stack) srcpad = gst_element_get_static_pad (source1, "src"); gst_pad_add_probe (srcpad, GST_PAD_PROBE_TYPE_EVENT_UPSTREAM, (GstPadProbeCallback) on_source1_pad_event_cb, NULL, NULL); + gst_object_unref (srcpad); /* def (default source) @@ -293,6 +294,7 @@ GST_START_TEST (test_remove_last_object) gst_element_set_state (GST_ELEMENT (pipeline), GST_STATE_NULL); gst_object_unref (pipeline); + gst_object_unref (bus); } GST_END_TEST; @@ -389,10 +391,10 @@ GST_START_TEST (test_simple_audiomixer) message = gst_bus_timed_pop_filtered (bus, GST_CLOCK_TIME_NONE, GST_MESSAGE_ASYNC_DONE | GST_MESSAGE_ERROR); - gst_mini_object_unref (GST_MINI_OBJECT (message)); if (GST_MESSAGE_TYPE (message) == GST_MESSAGE_ERROR) fail_error_message (message); + gst_mini_object_unref (GST_MINI_OBJECT (message)); GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS (GST_BIN (pipeline), GST_DEBUG_GRAPH_SHOW_ALL, "nle-simple-audiomixer-test-play"); diff --git a/tests/check/nle/tempochange.c b/tests/check/nle/tempochange.c index 3c1857dd15..f1ccf4e1e3 100644 --- a/tests/check/nle/tempochange.c +++ b/tests/check/nle/tempochange.c @@ -92,6 +92,7 @@ GST_START_TEST (test_tempochange) sinkpad = gst_element_get_static_pad (sink, "sink"); gst_pad_add_probe (sinkpad, GST_PAD_PROBE_TYPE_EVENT_DOWNSTREAM, (GstPadProbeCallback) sinkpad_probe, collect, NULL); + gst_object_unref (sinkpad); bus = gst_element_get_bus (GST_ELEMENT (pipeline));