From 607fd58a5ecc24ff84bb024a5a25a3c34f70f121 Mon Sep 17 00:00:00 2001
From: Antoine Tremblay <hexa00@gmail.com>
Date: Sun, 14 Sep 2008 22:01:30 +0000
Subject: [PATCH] gst/gstelement.c: Avoid leaking the parent ref when we fail
 changing the state of the element using gst_element_sync_...

Original commit message from CVS:
Based on patch by: Antoine Tremblay <hexa00 at gmail dot com>
* gst/gstelement.c: (gst_element_sync_state_with_parent):
Avoid leaking the parent ref when we fail changing the state of the
element using gst_element_sync_state_with_parent(). Fixes #551978.
---
 ChangeLog        | 8 ++++++++
 gst/gstelement.c | 1 +
 2 files changed, 9 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 4cd764e892..0e567c87a0 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2008-09-14  Wim Taymans  <wim.taymans@collabora.co.uk>
+
+	Based on patch by: Antoine Tremblay <hexa00 at gmail dot com>
+
+	* gst/gstelement.c: (gst_element_sync_state_with_parent):
+	Avoid leaking the parent ref when we fail changing the state of the
+	element using gst_element_sync_state_with_parent(). Fixes #551978.
+
 2008-09-11  Tim-Philipp Müller  <tim.muller at collabora co uk>
 
 	* docs/manual/intro-motivation.xml::
diff --git a/gst/gstelement.c b/gst/gstelement.c
index f67f3435ba..a5d8d18544 100644
--- a/gst/gstelement.c
+++ b/gst/gstelement.c
@@ -1840,6 +1840,7 @@ failed:
     GST_CAT_DEBUG_OBJECT (GST_CAT_STATES, element,
         "syncing state failed (%s)",
         gst_element_state_change_return_get_name (ret));
+    gst_object_unref (parent);
     return FALSE;
   }
 }