From 5e42c466570c3a2fc87bf10dd100f1a77d83232c Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Sun, 19 Feb 2006 14:32:35 +0000 Subject: [PATCH] ext/gnomevfs/gstgnomevfssink.c: use 0666 mask when creating files so umask gets applied correctly. Fixes #331295. Original commit message from CVS: * ext/gnomevfs/gstgnomevfssink.c: (gst_gnome_vfs_sink_open_file): use 0666 mask when creating files so umask gets applied correctly. Fixes #331295. --- ChangeLog | 6 ++++++ ext/gnomevfs/gstgnomevfssink.c | 13 ++++++++----- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index e80c1b963b..5886238f92 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2006-02-19 Wim Taymans + + * ext/gnomevfs/gstgnomevfssink.c: (gst_gnome_vfs_sink_open_file): + use 0666 mask when creating files so umask gets applied + correctly. Fixes #331295. + 2006-02-19 Tim-Philipp Müller * gst/subparse/Makefile.am: diff --git a/ext/gnomevfs/gstgnomevfssink.c b/ext/gnomevfs/gstgnomevfssink.c index 9114d65062..f838aacf87 100644 --- a/ext/gnomevfs/gstgnomevfssink.c +++ b/ext/gnomevfs/gstgnomevfssink.c @@ -331,11 +331,13 @@ gst_gnome_vfs_sink_open_file (GstGnomeVFSSink * sink) GnomeVFSResult result; if (sink->uri) { - /* open the file */ + /* open the file, all permissions, umask will apply */ result = gnome_vfs_create_uri (&(sink->handle), sink->uri, GNOME_VFS_OPEN_WRITE, TRUE, - GNOME_VFS_PERM_USER_READ | GNOME_VFS_PERM_USER_WRITE - | GNOME_VFS_PERM_GROUP_READ); + GNOME_VFS_PERM_USER_READ | GNOME_VFS_PERM_USER_WRITE | + GNOME_VFS_PERM_GROUP_READ | GNOME_VFS_PERM_GROUP_WRITE | + GNOME_VFS_PERM_OTHER_READ | GNOME_VFS_PERM_OTHER_WRITE); + /* if the file existed and the property says to ask, then ask! */ if (result == GNOME_VFS_ERROR_FILE_EXISTS) { gboolean erase_anyway = FALSE; @@ -346,8 +348,9 @@ gst_gnome_vfs_sink_open_file (GstGnomeVFSSink * sink) if (erase_anyway) { result = gnome_vfs_create_uri (&(sink->handle), sink->uri, GNOME_VFS_OPEN_WRITE, FALSE, - GNOME_VFS_PERM_USER_READ | GNOME_VFS_PERM_USER_WRITE - | GNOME_VFS_PERM_GROUP_READ); + GNOME_VFS_PERM_USER_READ | GNOME_VFS_PERM_USER_WRITE | + GNOME_VFS_PERM_GROUP_READ | GNOME_VFS_PERM_GROUP_WRITE | + GNOME_VFS_PERM_OTHER_READ | GNOME_VFS_PERM_OTHER_WRITE); } }