From 5d4e45fe36f5d471a26ad3c6b7cf1fb2ae7a5a24 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phane=20Cerveau?= <scerveau@collabora.com>
Date: Mon, 8 Feb 2021 12:24:58 +0100
Subject: [PATCH] dtls: use GST_WARNING instead of g_warning

No need a g_warning which is failing always
with gst-inspect -a

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2010>
---
 ext/dtls/gstdtlssrtpbin.c | 3 ++-
 ext/dtls/gstdtlssrtpdec.c | 9 +++++++--
 ext/dtls/gstdtlssrtpenc.c | 9 +++++++--
 3 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/ext/dtls/gstdtlssrtpbin.c b/ext/dtls/gstdtlssrtpbin.c
index acbac30eab..2a786e9c58 100644
--- a/ext/dtls/gstdtlssrtpbin.c
+++ b/ext/dtls/gstdtlssrtpbin.c
@@ -218,7 +218,8 @@ gst_dtls_srtp_bin_get_property (GObject * object,
         g_object_get_property (G_OBJECT (self->dtls_element), "connection-id",
             value);
       } else {
-        g_warning ("tried to get connection-id after disabling DTLS");
+        GST_WARNING_OBJECT (self,
+            "tried to get connection-id after disabling DTLS");
       }
       break;
     case PROP_KEY:
diff --git a/ext/dtls/gstdtlssrtpdec.c b/ext/dtls/gstdtlssrtpdec.c
index 72abfdacb4..8db69ba088 100644
--- a/ext/dtls/gstdtlssrtpdec.c
+++ b/ext/dtls/gstdtlssrtpdec.c
@@ -288,8 +288,13 @@ gst_dtls_srtp_dec_get_property (GObject * object,
       }
       break;
     case PROP_CONNECTION_STATE:
-      g_object_get_property (G_OBJECT (self->bin.dtls_element),
-          "connection-state", value);
+      if (self->bin.dtls_element) {
+        g_object_get_property (G_OBJECT (self->bin.dtls_element),
+            "connection-state", value);
+      } else {
+        GST_WARNING_OBJECT (self,
+            "tried to get connection-state after disabling DTLS");
+      }
       break;
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (self, prop_id, pspec);
diff --git a/ext/dtls/gstdtlssrtpenc.c b/ext/dtls/gstdtlssrtpenc.c
index 283ad9db63..11f5198cb8 100644
--- a/ext/dtls/gstdtlssrtpenc.c
+++ b/ext/dtls/gstdtlssrtpenc.c
@@ -327,8 +327,13 @@ gst_dtls_srtp_enc_get_property (GObject * object,
       }
       break;
     case PROP_CONNECTION_STATE:
-      g_object_get_property (G_OBJECT (self->bin.dtls_element),
-          "connection-state", value);
+      if (self->bin.dtls_element) {
+        g_object_get_property (G_OBJECT (self->bin.dtls_element),
+            "connection-state", value);
+      } else {
+        GST_WARNING_OBJECT (self,
+            "tried to get connection-state after disabling DTLS");
+      }
       break;
     case PROP_RTP_SYNC:
       g_value_set_boolean (value, self->rtp_sync);