From 5b68b64617f08939e2b14a0ad88e1996504c544d Mon Sep 17 00:00:00 2001 From: Jonathan Matthew Date: Thu, 4 Nov 2010 16:42:07 +1000 Subject: [PATCH] icydemux: fix use-after-free of taglist Broken by commit 4c2f5333 (bug #630205). https://bugzilla.gnome.org/show_bug.cgi?id=633970 --- gst/icydemux/gsticydemux.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gst/icydemux/gsticydemux.c b/gst/icydemux/gsticydemux.c index b7070a3df0..e3883a9f16 100644 --- a/gst/icydemux/gsticydemux.c +++ b/gst/icydemux/gsticydemux.c @@ -375,13 +375,15 @@ static gboolean gst_icydemux_handle_event (GstPad * pad, GstEvent * event) { GstICYDemux *icydemux = GST_ICYDEMUX (GST_PAD_PARENT (pad)); + gboolean result; if (GST_EVENT_TYPE (event) == GST_EVENT_TAG) { GstTagList *tags; gst_event_parse_tag (event, &tags); + result = gst_icydemux_tag_found (icydemux, tags); gst_event_unref (event); - return gst_icydemux_tag_found (icydemux, tags); + return result; } if (icydemux->typefinding) {