From 58859c8ee9d2517e95e452372b7ac004d17b35bd Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Sun, 7 Jun 2020 18:42:21 +0200 Subject: [PATCH] check: Avoid race with leaks test The problem is that the taskpool might not have completely drained by the time we check for leaks. Instead, ensure all tasks have stopped before testing for valid results. Part-of: --- tests/check/elements/leaks.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/check/elements/leaks.c b/tests/check/elements/leaks.c index 3ec7bb6046..c457226087 100644 --- a/tests/check/elements/leaks.c +++ b/tests/check/elements/leaks.c @@ -169,6 +169,9 @@ GST_START_TEST (test_get_live_objects) GST_STATE_CHANGE_SUCCESS); gst_object_unref (pipe); + /* Force all leftover tasks to stop */ + gst_task_cleanup_all (); + /* Check the live-objects data returned by the tracer */ { guint ii, size; @@ -251,6 +254,9 @@ GST_START_TEST (test_get_live_objects_filtered_detailed) GST_STATE_CHANGE_SUCCESS); gst_object_unref (pipe); + /* Force all leftover tasks to stop */ + gst_task_cleanup_all (); + /* Check the live-objects data returned by the tracer */ { guint ii, jj, isize, jsize; @@ -432,6 +438,9 @@ GST_START_TEST (test_activity_get_checkpoint) GST_STATE_CHANGE_SUCCESS); gst_object_unref (pipe); + /* Force all leftover tasks to stop */ + gst_task_cleanup_all (); + { GstStructure *cpoint; const GstStructure *cs, *rs;