From 56f2c474009bc5b5d6338f901257823212642cde Mon Sep 17 00:00:00 2001 From: Seungha Yang Date: Mon, 15 Jan 2024 22:44:09 +0900 Subject: [PATCH] appsrc: Release lock before pushing segment event Do not hold lock during event push. Similar fix to the commit 2e5908d33f14e178da6baf411b96f82116324e2f but another place Part-of: --- subprojects/gst-plugins-base/gst-libs/gst/app/gstappsrc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/subprojects/gst-plugins-base/gst-libs/gst/app/gstappsrc.c b/subprojects/gst-plugins-base/gst-libs/gst/app/gstappsrc.c index d80d8b534d..4492e5b63f 100644 --- a/subprojects/gst-plugins-base/gst-libs/gst/app/gstappsrc.c +++ b/subprojects/gst-plugins-base/gst-libs/gst/app/gstappsrc.c @@ -1621,12 +1621,18 @@ gst_app_src_create (GstBaseSrc * bsrc, guint64 offset, guint size, if (!gst_segment_is_equal (&priv->current_segment, segment)) { GST_DEBUG_OBJECT (appsrc, "Update new segment %" GST_PTR_FORMAT, event); + + /* Release lock temporarily during event push */ + g_mutex_unlock (&priv->mutex); if (!gst_base_src_push_segment (bsrc, segment)) { GST_ERROR_OBJECT (appsrc, "Couldn't set new segment %" GST_PTR_FORMAT, event); gst_event_unref (event); + g_mutex_lock (&priv->mutex); goto invalid_segment; } + + g_mutex_lock (&priv->mutex); gst_segment_copy_into (segment, &priv->current_segment); }