From 53c797d6046c131f751c69fe83e9fe65d8e0da95 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Wed, 13 Jan 2016 23:40:20 +0100 Subject: [PATCH] wavparse: When flushing on EOS, don't process more data than the "data" size Even if we have more data queued up when flushing than the size of the data chunk, don't process and output it. If the data size is known, this likely contains another chunk (e.g. an INFO chunk) or things like ID3 tags. Just outputting them as if they were data is going to cause unexpected behaviour and unpleasant audio noises. --- gst/wavparse/gstwavparse.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/gst/wavparse/gstwavparse.c b/gst/wavparse/gstwavparse.c index 1452db4ae8..687a41aae6 100644 --- a/gst/wavparse/gstwavparse.c +++ b/gst/wavparse/gstwavparse.c @@ -2322,8 +2322,6 @@ gst_wavparse_flush_data (GstWavParse * wav) guint av; if ((av = gst_adapter_available (wav->adapter)) > 0) { - wav->dataleft = av; - wav->end_offset = wav->offset + av; ret = gst_wavparse_stream_data (wav); }