From 53320460cb850bee2dd2021c5745a1628246e19d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Wed, 8 Jul 2020 09:53:42 +0100 Subject: [PATCH] pkgconfig: fix meson warnings about GL_CFLAGS in gstreamer-gl .pc files We added GL_CFLAGS in autotools because we unconditionally included OpenGL headers. We do not do that anymore for a standard #include . OpenGL headers are only included for the platform specific files e.g. #include which must always be hidden behind a #if GST_GL_HAVE_WINDOW_X11, or #include to gain access to the contents of the GstGLFuncs object. Users of our headers must include the necessary include paths for the platforms they are intending to support. We might introduce extra .pc files for what GstGL was built against though. Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues/735 Part-of: --- pkgconfig/gstreamer-gl-uninstalled.pc.in | 3 +-- pkgconfig/gstreamer-gl.pc.in | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/pkgconfig/gstreamer-gl-uninstalled.pc.in b/pkgconfig/gstreamer-gl-uninstalled.pc.in index 69e37e3de9..8beed593f3 100644 --- a/pkgconfig/gstreamer-gl-uninstalled.pc.in +++ b/pkgconfig/gstreamer-gl-uninstalled.pc.in @@ -14,5 +14,4 @@ Version: @VERSION@ Requires: gstreamer-video-@GST_API_VERSION@ gstreamer-base-@GST_API_VERSION@ gstreamer-@GST_API_VERSION@ Libs: -L${libdir} -lgstgl-@GST_API_VERSION@ -Cflags: -I@abs_top_srcdir@/gst-libs -I@abs_top_builddir@/gst-libs @GL_CFLAGS@ - +Cflags: -I@abs_top_srcdir@/gst-libs -I@abs_top_builddir@/gst-libs diff --git a/pkgconfig/gstreamer-gl.pc.in b/pkgconfig/gstreamer-gl.pc.in index dc672a97b8..8c290bab51 100644 --- a/pkgconfig/gstreamer-gl.pc.in +++ b/pkgconfig/gstreamer-gl.pc.in @@ -13,4 +13,4 @@ Version: @VERSION@ Requires: gstreamer-video-@GST_API_VERSION@ gstreamer-base-@GST_API_VERSION@ gstreamer-@GST_API_VERSION@ Libs: -L${libdir} -lgstgl-@GST_API_VERSION@ -Cflags: -I${includedir} -I${libdir}/gstreamer-@GST_API_VERSION@/include @GL_CFLAGS@ +Cflags: -I${includedir} -I${libdir}/gstreamer-@GST_API_VERSION@/include