From 52d4b7de076f5b964ca5dfb904b9bf8408781f29 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Wed, 18 Jun 2014 15:36:09 +0200 Subject: [PATCH] srtpenc: improve property comments Add a Note to the allow-repeat-tx property because it is potentially insecure when used incorrectly. Fixes https://bugzilla.gnome.org/show_bug.cgi?id=731714 --- ext/srtp/gstsrtpenc.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ext/srtp/gstsrtpenc.c b/ext/srtp/gstsrtpenc.c index 276076fa67..2dd4bc990e 100644 --- a/ext/srtp/gstsrtpenc.c +++ b/ext/srtp/gstsrtpenc.c @@ -324,8 +324,11 @@ gst_srtp_enc_class_init (GstSrtpEncClass * klass) 64, 0x8000, DEFAULT_REPLAY_WINDOW_SIZE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); g_object_class_install_property (gobject_class, PROP_ALLOW_REPEAT_TX, - g_param_spec_boolean ("allow-repeat-tx", "Allow repeat packets transmission", - "Whether retransmissions of packets with the same sequence number are allowed", + g_param_spec_boolean ("allow-repeat-tx", + "Allow repeat packets transmission", + "Whether retransmissions of packets with the same sequence number are allowed" + "(Note that such repeated transmissions must have the same RTP payload, " + "or a severe security weakness is introduced!)", DEFAULT_ALLOW_REPEAT_TX, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); /**