From 517ab2860e90b2c6d255096dd02409434f4bb62b Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Thu, 22 Oct 2009 13:15:15 +0200 Subject: [PATCH] gsturi: Optimisation: Avoid type-checking in sorting method. We already know the list only contains plugin features --- gst/gsturi.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/gst/gsturi.c b/gst/gsturi.c index ab9c4bba03..4065abd394 100644 --- a/gst/gsturi.c +++ b/gst/gsturi.c @@ -517,11 +517,8 @@ search_by_entry (GstPluginFeature * feature, gpointer search_entry) } static gint -sort_by_rank (gconstpointer a, gconstpointer b) +sort_by_rank (GstPluginFeature * first, GstPluginFeature * second) { - GstPluginFeature *first = GST_PLUGIN_FEATURE (a); - GstPluginFeature *second = GST_PLUGIN_FEATURE (b); - return gst_plugin_feature_get_rank (second) - gst_plugin_feature_get_rank (first); } @@ -603,7 +600,7 @@ gst_element_make_from_uri (const GstURIType type, const gchar * uri, return NULL; } - possibilities = g_list_sort (possibilities, sort_by_rank); + possibilities = g_list_sort (possibilities, (GCompareFunc) sort_by_rank); walk = possibilities; while (walk) { if ((ret =