From 4e676414f0cc60889d407de9d917e551bda55052 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Wed, 27 Jun 2007 09:49:51 +0000 Subject: [PATCH] ext/vorbis/vorbisdec.c: Don't error out on 0-sized packets, just emit a warning because this is not a fatal error. Fi... Original commit message from CVS: * ext/vorbis/vorbisdec.c: (vorbis_dec_decode_buffer): Don't error out on 0-sized packets, just emit a warning because this is not a fatal error. Fixes #451145. --- ChangeLog | 6 ++++++ ext/vorbis/vorbisdec.c | 7 +++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index b0f1ada4af..f8907b3a17 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2007-06-27 Wim Taymans + + * ext/vorbis/vorbisdec.c: (vorbis_dec_decode_buffer): + Don't error out on 0-sized packets, just emit a warning because this is + not a fatal error. Fixes #451145. + 2007-06-25 Stefan Kost * docs/plugins/gst-plugins-base-plugins.args: diff --git a/ext/vorbis/vorbisdec.c b/ext/vorbis/vorbisdec.c index 35a84f2c3c..fa11617854 100644 --- a/ext/vorbis/vorbisdec.c +++ b/ext/vorbis/vorbisdec.c @@ -1150,8 +1150,11 @@ done: /* ERRORS */ wrong_size: { - GST_ELEMENT_ERROR (vd, STREAM, DECODE, (NULL), ("empty buffer received")); - result = GST_FLOW_ERROR; + /* don't error out here, just ignore the buffer, it's invalid for vorbis but + * not fatal. */ + GST_ELEMENT_WARNING (vd, STREAM, DECODE, (NULL), + ("empty buffer received, ignoring")); + result = GST_FLOW_OK; vd->discont = TRUE; goto done; }