From 4d7d577496ec4a54a9f11e5aa82573e535f41fcf Mon Sep 17 00:00:00 2001 From: Joakim Johansson Date: Mon, 16 Dec 2019 13:03:51 +0100 Subject: [PATCH] gstrtspsrc: Add missing lock on free set_get_param_q Otherwise is it possible to get a crash in gst_rtspsrc_set_parameter. --- gst/rtsp/gstrtspsrc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gst/rtsp/gstrtspsrc.c b/gst/rtsp/gstrtspsrc.c index 4c79b473ab..f63c3ddc13 100644 --- a/gst/rtsp/gstrtspsrc.c +++ b/gst/rtsp/gstrtspsrc.c @@ -2455,10 +2455,13 @@ gst_rtspsrc_cleanup (GstRTSPSrc * src) src->provided_clock = NULL; } + GST_OBJECT_LOCK (src); /* free parameter requests queue */ if (!g_queue_is_empty (&src->set_get_param_q)) g_queue_free_full (&src->set_get_param_q, free_param_queue); + GST_OBJECT_UNLOCK (src); + } static gboolean