From 4cf2d8431536c040ccc92a096f6745021e41699d Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Wed, 22 Jul 2015 16:58:12 -0400 Subject: [PATCH] glupload: Forward composition meta even without params When the sink does not know the window size (e.g not created yet) it will not add any param to the the composition meta. This is no reason not to forward this meta API. Fixes issue where it could not attach until we resize the window. https://bugzilla.gnome.org/show_bug.cgi?id=745107 --- ext/gl/gstgluploadelement.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ext/gl/gstgluploadelement.c b/ext/gl/gstgluploadelement.c index 6ed3f1cc0e..0b35ec9c51 100644 --- a/ext/gl/gstgluploadelement.c +++ b/ext/gl/gstgluploadelement.c @@ -161,10 +161,10 @@ _gst_gl_upload_element_propose_allocation (GstBaseTransform * bt, /* read window size from decide_query */ gst_query_parse_nth_allocation_meta (decide_query, alloc_index, ¶ms); - if (params) - gst_query_add_allocation_meta (query, - GST_VIDEO_OVERLAY_COMPOSITION_META_API_TYPE, params); - + /* it does not matter if params are NULL (no known window size), forward + * the meta in any case */ + gst_query_add_allocation_meta (query, + GST_VIDEO_OVERLAY_COMPOSITION_META_API_TYPE, params); } gst_gl_upload_propose_allocation (upload->upload, decide_query, query);