From 4b7e377d2563697a4b13d401112195d1fa4cb451 Mon Sep 17 00:00:00 2001 From: Luis de Bethencourt Date: Fri, 1 Apr 2016 12:15:05 +0100 Subject: [PATCH] rtpvorbisdepay: remove dead code payload_buffer hasn't been assigned a value before the jumps to switch_failed or packet_short. So the value must be NULL. No need to unmap and unref. CID #1316476 --- gst/rtp/gstrtpvorbisdepay.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/gst/rtp/gstrtpvorbisdepay.c b/gst/rtp/gstrtpvorbisdepay.c index fdd5eb84e7..762750a0a3 100644 --- a/gst/rtp/gstrtpvorbisdepay.c +++ b/gst/rtp/gstrtpvorbisdepay.c @@ -612,20 +612,12 @@ switch_failed: { GST_ELEMENT_WARNING (rtpvorbisdepay, STREAM, DECODE, (NULL), ("Could not switch codebooks")); - if (payload_buffer) { - gst_buffer_unmap (payload_buffer, &map); - gst_buffer_unref (payload_buffer); - } return NULL; } packet_short: { GST_ELEMENT_WARNING (rtpvorbisdepay, STREAM, DECODE, (NULL), ("Packet was too short (%d < 4)", payload_len)); - if (payload_buffer) { - gst_buffer_unmap (payload_buffer, &map); - gst_buffer_unref (payload_buffer); - } return NULL; } ignore_reserved: