From 4a41f6f3febeef93078995f213c38087a998ae2c Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Tue, 29 Oct 2024 11:29:05 +0100 Subject: [PATCH] srt: Don't attempt to reconnect on authentication failures This is a fatal issue which can't be recovered Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1550 Part-of: --- subprojects/gst-plugins-bad/ext/srt/gstsrtobject.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/subprojects/gst-plugins-bad/ext/srt/gstsrtobject.c b/subprojects/gst-plugins-bad/ext/srt/gstsrtobject.c index 986c643a40..a88b8ccc0c 100644 --- a/subprojects/gst-plugins-bad/ext/srt/gstsrtobject.c +++ b/subprojects/gst-plugins-bad/ext/srt/gstsrtobject.c @@ -732,6 +732,8 @@ gst_srt_object_install_properties_helper (GObjectClass * gobject_class) * Boolean to choose whether to automatically reconnect. If TRUE, an element * in caller mode will try to reconnect instead of reporting an error. * + * This will be ignored for authentication failures. + * * Since: 1.22 * */ @@ -1600,6 +1602,8 @@ retry: g_set_error (&internal_error, GST_RESOURCE_ERROR, GST_RESOURCE_ERROR_NOT_AUTHORIZED, "Failed to authenticate: %" REASON_FORMAT, REASON_ARGS (reason)); + /* Failure to authenticate are fatal */ + auto_reconnect = FALSE; } else { g_set_error (&internal_error, GST_RESOURCE_ERROR, GST_RESOURCE_ERROR_READ,