From 490444637f98702fa49461d89e2dd019673cce52 Mon Sep 17 00:00:00 2001 From: Thibault Saunier Date: Mon, 26 Jan 2015 11:32:47 +0100 Subject: [PATCH] aggregator: More fixes around locking when accessing protected private fields In some more places we were accessing GstAggregator->segment and GstAggregator->seqnum without holding the GST_OBJECT_LOCK https://bugzilla.gnome.org/show_bug.cgi?id=742684 --- gst-libs/gst/video/gstvideoaggregator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gst-libs/gst/video/gstvideoaggregator.c b/gst-libs/gst/video/gstvideoaggregator.c index 3ec08b974e..2a8a48c4dc 100644 --- a/gst-libs/gst/video/gstvideoaggregator.c +++ b/gst-libs/gst/video/gstvideoaggregator.c @@ -1615,8 +1615,8 @@ gst_videoaggregator_flush (GstAggregator * agg) GstVideoAggregator *vagg = GST_VIDEO_AGGREGATOR (agg); GST_INFO_OBJECT (agg, "Flushing"); - abs_rate = ABS (agg->segment.rate); GST_OBJECT_LOCK (vagg); + abs_rate = ABS (agg->segment.rate); for (l = GST_ELEMENT (vagg)->sinkpads; l; l = l->next) { GstVideoAggregatorPad *p = l->data;