From 48a4fd4e5058a17ee5d592524322e3c6a7721e1c Mon Sep 17 00:00:00 2001 From: Miguel Paris Date: Thu, 29 Nov 2018 13:48:33 +0100 Subject: [PATCH] rtpsession: properly handle rtcp_feedback_retention_window - Consider GST_CLOCK_TIME_NONE as not to be used. - Complete "rtcp-feedback-retention-window" property getter/setter implementation. --- gst/rtpmanager/rtpsession.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/gst/rtpmanager/rtpsession.c b/gst/rtpmanager/rtpsession.c index 98dd887927..623daf2131 100644 --- a/gst/rtpmanager/rtpsession.c +++ b/gst/rtpmanager/rtpsession.c @@ -821,6 +821,9 @@ rtp_session_set_property (GObject * object, guint prop_id, if (sess->callbacks.reconsider) sess->callbacks.reconsider (sess, sess->reconsider_user_data); break; + case PROP_RTCP_FEEDBACK_RETENTION_WINDOW: + sess->rtcp_feedback_retention_window = g_value_get_uint64 (value); + break; case PROP_RTCP_IMMEDIATE_FEEDBACK_THRESHOLD: sess->rtcp_immediate_feedback_threshold = g_value_get_uint (value); break; @@ -900,6 +903,9 @@ rtp_session_get_property (GObject * object, guint prop_id, case PROP_RTCP_MIN_INTERVAL: g_value_set_uint64 (value, sess->stats.min_interval * GST_SECOND); break; + case PROP_RTCP_FEEDBACK_RETENTION_WINDOW: + g_value_set_uint64 (value, sess->rtcp_feedback_retention_window); + break; case PROP_RTCP_IMMEDIATE_FEEDBACK_THRESHOLD: g_value_set_uint (value, sess->rtcp_immediate_feedback_threshold); break; @@ -2818,7 +2824,7 @@ rtp_session_process_feedback (RTPSession * sess, GstRTCPPacket * packet, gst_buffer_unref (fci_buffer); } - if (src && sess->rtcp_feedback_retention_window) { + if (src && sess->rtcp_feedback_retention_window != GST_CLOCK_TIME_NONE) { rtp_source_retain_rtcp_packet (src, packet, pinfo->running_time); }