From 486fe43cb97e7c961893c1d1854e7462a3b040a4 Mon Sep 17 00:00:00 2001
From: Stefan Kost <ensonic@users.sf.net>
Date: Mon, 2 Feb 2009 18:05:42 +0200
Subject: [PATCH] Add a FIXME 0.11. Make the log message a bit more detailed
 and add comments.

---
 gst-libs/gst/audio/gstaudiosink.c | 6 ++++--
 gst-libs/gst/audio/gstaudiosink.h | 2 ++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/gst-libs/gst/audio/gstaudiosink.c b/gst-libs/gst/audio/gstaudiosink.c
index b4b457176f..b4ceacba9e 100644
--- a/gst-libs/gst/audio/gstaudiosink.c
+++ b/gst-libs/gst/audio/gstaudiosink.c
@@ -237,9 +237,11 @@ audioringbuffer_thread_func (GstRingBuffer * buf)
         GST_LOG_OBJECT (sink, "transfered %d bytes of %d from segment %d",
             written, left, readseg);
         if (written < 0 || written > left) {
+          /* might not be critical, it e.g. happens when aborting playback */
           GST_WARNING_OBJECT (sink,
-              "error writing data (reason: %s), skipping segment",
-              g_strerror (errno));
+              "error writing data in %s (reason: %s), skipping segment (left: %d, written: %d)",
+              GST_DEBUG_FUNCPTR_NAME (writefunc),
+              (errno > 1 ? g_strerror (errno) : "unknown"), left, written);
           break;
         }
         left -= written;
diff --git a/gst-libs/gst/audio/gstaudiosink.h b/gst-libs/gst/audio/gstaudiosink.h
index ff9b8caf8e..83a4e952c5 100644
--- a/gst-libs/gst/audio/gstaudiosink.h
+++ b/gst-libs/gst/audio/gstaudiosink.h
@@ -83,6 +83,8 @@ struct _GstAudioSinkClass {
   /* close the device */
   gboolean (*close)     (GstAudioSink *sink);
   /* write samples to the device */
+  /* FIXME 0.11: change return value to gint, as most implementation use that
+   * already anyway */
   guint    (*write)     (GstAudioSink *sink, gpointer data, guint length);
   /* get number of samples queued in the device */
   guint    (*delay)     (GstAudioSink *sink);