From 484291b1b406a77c465ae9621e9d8cfc5825f9cc Mon Sep 17 00:00:00 2001 From: "Jan Alexander Steffens (heftig)" Date: Mon, 14 Jan 2019 14:37:23 +0100 Subject: [PATCH] srt: Fix GCC function type error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit gstsrtobject.c: In function ‘gst_srt_object_close’: gstsrtobject.c:1036:7: error: function called through a non-compatible type [-Werror] (GDestroyNotify) g_closure_unref); /usr/include/glib-2.0/glib/gmem.h:121:8: note: in definition of macro ‘g_clear_pointer’ (destroy) (_ptr); \ ^~~~~~~ gstsrtobject.c:1038:7: error: function called through a non-compatible type [-Werror] (GDestroyNotify) g_closure_unref); /usr/include/glib-2.0/glib/gmem.h:121:8: note: in definition of macro ‘g_clear_pointer’ (destroy) (_ptr); \ ^~~~~~~ Arch Linux gcc 8.2.1 20181127 glib 2.58.2 --- ext/srt/gstsrtobject.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ext/srt/gstsrtobject.c b/ext/srt/gstsrtobject.c index 0716a65db3..3722a4ba89 100644 --- a/ext/srt/gstsrtobject.c +++ b/ext/srt/gstsrtobject.c @@ -1032,10 +1032,8 @@ gst_srt_object_close (GstSRTObject * srtobject) srtobject); g_list_free_full (srtobject->callers, (GDestroyNotify) srt_caller_free); - g_clear_pointer (&srtobject->caller_added_closure, - (GDestroyNotify) g_closure_unref); - g_clear_pointer (&srtobject->caller_removed_closure, - (GDestroyNotify) g_closure_unref); + g_clear_pointer (&srtobject->caller_added_closure, g_closure_unref); + g_clear_pointer (&srtobject->caller_removed_closure, g_closure_unref); srtobject->opened = FALSE; }