From 481e1f76e84e272fee49c9c8ee8d1af28f916c00 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20Par=C3=ADs=20D=C3=ADaz?= Date: Wed, 13 May 2015 13:14:14 +0200 Subject: [PATCH] srtpenc: fix over unlocking Called should call function with lock, and is also responsible for unlocking it later. https://bugzilla.gnome.org/show_bug.cgi?id=749304 --- ext/srtp/gstsrtpenc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ext/srtp/gstsrtpenc.c b/ext/srtp/gstsrtpenc.c index bf1b811ad0..f5e3f13f74 100644 --- a/ext/srtp/gstsrtpenc.c +++ b/ext/srtp/gstsrtpenc.c @@ -425,7 +425,6 @@ gst_srtp_enc_create_session (GstSrtpEnc * filter) gsize keysize; if (filter->key == NULL) { - GST_OBJECT_UNLOCK (filter); GST_ELEMENT_ERROR (filter, LIBRARY, SETTINGS, ("Cipher is not NULL, key must be set"), ("Cipher is not NULL, key must be set")); @@ -436,7 +435,6 @@ gst_srtp_enc_create_session (GstSrtpEnc * filter) keysize = gst_buffer_get_size (filter->key); if (expected != keysize) { - GST_OBJECT_UNLOCK (filter); GST_ELEMENT_ERROR (filter, LIBRARY, SETTINGS, ("Master key size is wrong"), ("Expected master key of %d bytes, but received %" G_GSIZE_FORMAT