From 48130e07a1b322a28e1e269f5965956ac05fb40b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Tue, 9 Jul 2019 14:51:41 +0300 Subject: [PATCH] Add FIXME comment to the Rust sendrecv example for implementation proper SDP negotiation --- webrtc/sendrecv/gst-rust/src/main.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/webrtc/sendrecv/gst-rust/src/main.rs b/webrtc/sendrecv/gst-rust/src/main.rs index 04b31db07c..83dfe3ed8d 100644 --- a/webrtc/sendrecv/gst-rust/src/main.rs +++ b/webrtc/sendrecv/gst-rust/src/main.rs @@ -582,6 +582,10 @@ impl App { } else if type_ == "offer" { print!("Received offer:\n{}\n", sdp); + // FIXME: We need to do negotiation here based on what the peer offers us in the SDP + // and what we can produce. For example all RTCP or RTP header extensions we don't + // understand have to be removed, and similarly we have to negotiate the codecs. + // Need to start the pipeline as a first step here self.setup_pipeline()?;