diff --git a/ChangeLog b/ChangeLog index 01f60b897c..b608ba6c01 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,20 @@ +2007-03-08 Jan Schmidt + + * ext/alsa/gstalsasink.c: (gst_alsasink_open): + Extra log line. + + * ext/pango/gstclockoverlay.c: (gst_clock_overlay_init): + * ext/pango/gsttimeoverlay.c: (gst_time_overlay_init): + Use pango_font_description_set_family_static instead of + pango_font_description_set_family to save a string copy (it was + leaking due to the strdup anyway) + + * gst/tcp/gsttcpclientsink.c: (gst_tcp_client_sink_finalize): + * gst/tcp/gsttcpclientsrc.c: (gst_tcp_client_src_finalize): + * gst/tcp/gsttcpserversink.c: (gst_tcp_server_sink_finalize): + * gst/tcp/gsttcpserversrc.c: (gst_tcp_server_src_finalize): + Chain up in finalize. + 2007-03-07 Tim-Philipp Müller * gst-libs/gst/interfaces/mixertrack.c: diff --git a/common b/common index c4f56a657d..7c5a0ab68d 160000 --- a/common +++ b/common @@ -1 +1 @@ -Subproject commit c4f56a657d79aee0e3fc25ef2bcf876f9f3c1593 +Subproject commit 7c5a0ab68de1fed4e5a1fd473160debc2c4c7b89 diff --git a/ext/alsa/gstalsasink.c b/ext/alsa/gstalsasink.c index 7e025dde2e..0329d4f115 100644 --- a/ext/alsa/gstalsasink.c +++ b/ext/alsa/gstalsasink.c @@ -610,6 +610,7 @@ gst_alsasink_open (GstAudioSink * asink) CHECK (snd_pcm_open (&alsa->handle, alsa->device, SND_PCM_STREAM_PLAYBACK, SND_PCM_NONBLOCK), open_error); + GST_LOG_OBJECT (alsa, "Opened device %s", alsa->device); return TRUE; diff --git a/ext/pango/gstclockoverlay.c b/ext/pango/gstclockoverlay.c index 442eda99a7..efffb024ab 100644 --- a/ext/pango/gstclockoverlay.c +++ b/ext/pango/gstclockoverlay.c @@ -143,7 +143,7 @@ gst_clock_overlay_init (GstClockOverlay * overlay, GstClockOverlayClass * klass) pango_context_set_base_dir (context, PANGO_DIRECTION_LTR); font_description = pango_font_description_new (); - pango_font_description_set_family (font_description, g_strdup ("Monospace")); + pango_font_description_set_family_static (font_description, "Monospace"); pango_font_description_set_style (font_description, PANGO_STYLE_NORMAL); pango_font_description_set_variant (font_description, PANGO_VARIANT_NORMAL); pango_font_description_set_weight (font_description, PANGO_WEIGHT_NORMAL); diff --git a/ext/pango/gsttimeoverlay.c b/ext/pango/gsttimeoverlay.c index 640ddb3e93..20c27090ec 100644 --- a/ext/pango/gsttimeoverlay.c +++ b/ext/pango/gsttimeoverlay.c @@ -146,7 +146,7 @@ gst_time_overlay_init (GstTimeOverlay * overlay, GstTimeOverlayClass * klass) pango_context_set_base_dir (context, PANGO_DIRECTION_LTR); font_description = pango_font_description_new (); - pango_font_description_set_family (font_description, g_strdup ("Monospace")); + pango_font_description_set_family_static (font_description, "Monospace"); pango_font_description_set_style (font_description, PANGO_STYLE_NORMAL); pango_font_description_set_variant (font_description, PANGO_VARIANT_NORMAL); pango_font_description_set_weight (font_description, PANGO_WEIGHT_NORMAL); diff --git a/gst/tcp/gsttcpclientsink.c b/gst/tcp/gsttcpclientsink.c index d863e84065..32a95c4272 100644 --- a/gst/tcp/gsttcpclientsink.c +++ b/gst/tcp/gsttcpclientsink.c @@ -171,6 +171,8 @@ gst_tcp_client_sink_finalize (GObject * gobject) GstTCPClientSink *this = GST_TCP_CLIENT_SINK (gobject); g_free (this->host); + + G_OBJECT_CLASS (parent_class)->finalize (gobject); } static gboolean diff --git a/gst/tcp/gsttcpclientsrc.c b/gst/tcp/gsttcpclientsrc.c index b277feb3a6..87caea5864 100644 --- a/gst/tcp/gsttcpclientsrc.c +++ b/gst/tcp/gsttcpclientsrc.c @@ -168,6 +168,8 @@ gst_tcp_client_src_finalize (GObject * gobject) GstTCPClientSrc *this = GST_TCP_CLIENT_SRC (gobject); g_free (this->host); + + G_OBJECT_CLASS (parent_class)->finalize (gobject); } static GstCaps * diff --git a/gst/tcp/gsttcpserversink.c b/gst/tcp/gsttcpserversink.c index 5b35b8c842..a2c782ee74 100644 --- a/gst/tcp/gsttcpserversink.c +++ b/gst/tcp/gsttcpserversink.c @@ -132,6 +132,8 @@ gst_tcp_server_sink_finalize (GObject * gobject) GstTCPServerSink *this = GST_TCP_SERVER_SINK (gobject); g_free (this->host); + + G_OBJECT_CLASS (parent_class)->finalize (gobject); } /* handle a read request on the server, diff --git a/gst/tcp/gsttcpserversrc.c b/gst/tcp/gsttcpserversrc.c index 1cd674c60f..b638f438a8 100644 --- a/gst/tcp/gsttcpserversrc.c +++ b/gst/tcp/gsttcpserversrc.c @@ -163,6 +163,8 @@ gst_tcp_server_src_finalize (GObject * gobject) GstTCPServerSrc *src = GST_TCP_SERVER_SRC (gobject); g_free (src->host); + + G_OBJECT_CLASS (parent_class)->finalize (gobject); } static GstFlowReturn