From 45522aab4691501ad9db7828ad539111375679ac Mon Sep 17 00:00:00 2001 From: Stefan Kost Date: Tue, 16 Feb 2010 10:10:45 +0200 Subject: [PATCH] jpegenc: add a fixme for handling other YUV variants --- ext/jpeg/gstjpegenc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ext/jpeg/gstjpegenc.c b/ext/jpeg/gstjpegenc.c index 73e674c9ea..01f1665a2c 100644 --- a/ext/jpeg/gstjpegenc.c +++ b/ext/jpeg/gstjpegenc.c @@ -514,6 +514,11 @@ gst_jpegenc_chain (GstPad * pad, GstBuffer * buf) end[1] = base[1] + (height / 2) * I420_U_ROWSTRIDE (width); end[2] = base[2] + (height / 2) * I420_V_ROWSTRIDE (width); + /* FIXME: shouldn't we also set + * - jpegenc->cinfo.max_{v,h}_samp_factor + * - jpegenc->cinfo.comp_info[0,1,2].{v,h}_samp_factor + * accordingly? + */ jpegenc->jdest.next_output_byte = GST_BUFFER_DATA (jpegenc->output_buffer); jpegenc->jdest.free_in_buffer = GST_BUFFER_SIZE (jpegenc->output_buffer);