From 453438a9dd409a5debac8b1679ac9e3f344d4e37 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Mon, 11 Feb 2013 19:53:39 +0000 Subject: [PATCH] mxfdemux: fix push mode unit test failure In the sink event handler we end up sending multiple EOS events per pad. Don't return FALSE when sending the second EOS on an already-EOS pad fails. Not sure if there was a reason for sending a second EOS, so leaving the code in there for now, but assume all went fine if there are source pads, which is slightly less wrong than before. This function needs work. --- gst/mxf/mxfdemux.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gst/mxf/mxfdemux.c b/gst/mxf/mxfdemux.c index 04e8a48e69..0a9bb64095 100644 --- a/gst/mxf/mxfdemux.c +++ b/gst/mxf/mxfdemux.c @@ -3760,8 +3760,9 @@ gst_mxf_demux_sink_event (GstPad * pad, GstObject * parent, GstEvent * event) } } - if (!(ret = gst_pad_event_default (pad, parent, event))) - GST_WARNING_OBJECT (pad, "failed pushing EOS on streams"); + /* and one more time for good measure apparently? */ + gst_pad_event_default (pad, parent, event); + ret = (demux->src->len > 0); break; } case GST_EVENT_SEGMENT:{