From 43a656b29682a502c700f95ae80f276d64b7c9e9 Mon Sep 17 00:00:00 2001 From: Luis de Bethencourt Date: Tue, 12 Apr 2016 11:14:22 +0100 Subject: [PATCH] gltestsrc: don't dereference null pointer funcs can be NULL, it is one of the two conditions of the OR statement above, so confirm it isn't before dereferencing with funcs->free. CID 1358388 --- ext/gl/gstgltestsrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/gl/gstgltestsrc.c b/ext/gl/gstgltestsrc.c index b5d2fa4dda..45788ddc65 100644 --- a/ext/gl/gstgltestsrc.c +++ b/ext/gl/gstgltestsrc.c @@ -740,7 +740,7 @@ gst_gl_test_src_callback (gpointer stuff) funcs = src->src_funcs; if (!funcs || src->set_pattern != src->active_pattern) { - if (src->src_impl) + if (src->src_impl && funcs) funcs->free (src->src_impl); src->src_funcs = funcs = gst_gl_test_src_get_src_funcs_for_pattern (src->set_pattern);