From 40ee3369a0e0c555e94cdec06ab8b1303ca3c094 Mon Sep 17 00:00:00 2001 From: David Schleef Date: Sat, 25 Jun 2011 15:12:45 -0700 Subject: [PATCH] tta: decrease rank to NONE Appears to be utterly incapable of parsing and decoding TTA streams. Hasn't been updated to do TTA2. If you want this element to work, fix the bloody thing. The gst-ffmpeg decoder works fine. Also fixed an obvious endianness issue along the way. Fixes: #652924 --- gst/tta/gstttadec.c | 6 +++--- gst/tta/gstttaparse.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gst/tta/gstttadec.c b/gst/tta/gstttadec.c index e2c1f5a37a..4565272797 100644 --- a/gst/tta/gstttadec.c +++ b/gst/tta/gstttadec.c @@ -89,7 +89,7 @@ static GstStaticPadTemplate src_factory = GST_STATIC_PAD_TEMPLATE ("src", "depth = (int) { 8, 16, 24 }, " "channels = (int) { 1, 2 }, " "rate = (int) [ 8000, 96000 ], " - "endianness = (int) LITTLE_ENDIAN, " "signed = (boolean) true") + "endianness = (int) BYTE_ORDER, " "signed = (boolean) true") ); static void gst_tta_dec_class_init (GstTtaDecClass * klass); @@ -125,7 +125,7 @@ gst_tta_dec_setcaps (GstPad * pad, GstCaps * caps) "channels", G_TYPE_INT, ttadec->channels, "depth", G_TYPE_INT, bits, "width", G_TYPE_INT, bits, - "endianness", G_TYPE_INT, G_LITTLE_ENDIAN, + "endianness", G_TYPE_INT, G_BYTE_ORDER, "signed", G_TYPE_BOOLEAN, TRUE, NULL); if (!gst_pad_set_caps (ttadec->srcpad, srccaps)) @@ -445,5 +445,5 @@ gboolean gst_tta_dec_plugin_init (GstPlugin * plugin) { return gst_element_register (plugin, "ttadec", - GST_RANK_PRIMARY, GST_TYPE_TTA_DEC); + GST_RANK_NONE, GST_TYPE_TTA_DEC); } diff --git a/gst/tta/gstttaparse.c b/gst/tta/gstttaparse.c index fc2b02b308..069408ab60 100644 --- a/gst/tta/gstttaparse.c +++ b/gst/tta/gstttaparse.c @@ -495,7 +495,7 @@ gboolean gst_tta_parse_plugin_init (GstPlugin * plugin) { if (!gst_element_register (plugin, "ttaparse", - GST_RANK_PRIMARY, GST_TYPE_TTA_PARSE)) { + GST_RANK_NONE, GST_TYPE_TTA_PARSE)) { return FALSE; }