From 402086a82dbfaa85dfaf72aec24df9cf13db82f8 Mon Sep 17 00:00:00 2001 From: Vincent Penquerc'h Date: Thu, 12 Jun 2014 10:14:27 +0100 Subject: [PATCH] dvbsrc: do not try to close negative file descriptors Interestingly, Coverity implies that close takes an unsigned argument, while my close(2) man page shows it taking a signed argument. I guess it may be platforms specific. Coverity 1214602 --- sys/dvb/gstdvbsrc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dvb/gstdvbsrc.c b/sys/dvb/gstdvbsrc.c index 0c18a20d05..f8829d207e 100644 --- a/sys/dvb/gstdvbsrc.c +++ b/sys/dvb/gstdvbsrc.c @@ -1974,7 +1974,8 @@ gst_dvbsrc_set_pes_filters (GstDvbSrc * object) fd = &object->fd_filters[i]; pid = object->pids[i]; - close (*fd); + if (*fd >= 0) + close (*fd); if ((*fd = open (demux_dev, O_RDWR)) < 0) { GST_ERROR_OBJECT (object, "Error opening demuxer: %s (%s)", g_strerror (errno), demux_dev);