From 4008b872bbed7b0ced84592d0d56a4baa3ced9ef Mon Sep 17 00:00:00 2001 From: "Jan Alexander Steffens (heftig)" Date: Thu, 25 May 2023 17:02:24 +0200 Subject: [PATCH] fdkaacdec: Support up to 5 rear channels The `switch (n_rear)` supports up to 5 rear channels, but our channel set only had space for 3. Size the set properly to fix this. This didn't actually cause any memory unsafety as `PUSH_CHAN` would stop incrementing `n_rear` if the channel set is already full. Thanks to @alatiera for noticing this. Part-of: --- subprojects/gst-plugins-bad/ext/fdkaac/gstfdkaacdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/gst-plugins-bad/ext/fdkaac/gstfdkaacdec.c b/subprojects/gst-plugins-bad/ext/fdkaac/gstfdkaacdec.c index 8924b81509..e43a2f0416 100644 --- a/subprojects/gst-plugins-bad/ext/fdkaac/gstfdkaacdec.c +++ b/subprojects/gst-plugins-bad/ext/fdkaac/gstfdkaacdec.c @@ -237,7 +237,7 @@ gst_fdkaacdec_map_channels (GstFdkAacDec * self, const CStreamInfo * in, DEF_CHANSET (front, 7); DEF_CHANSET (side, 2); - DEF_CHANSET (rear, 3); + DEF_CHANSET (rear, 5); DEF_CHANSET (lfe, 2); DEF_CHANSET (top_front, 3); DEF_CHANSET (top_center, 3);