From 3fdfef15a1bd78e7af86e7b5e9628cf3fecdf822 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Wed, 23 Oct 2024 14:24:36 +0200 Subject: [PATCH] parsebin: Don't store bogus caps on GstStream If we can't get the current caps when receiving a stream-start, that's fine, they can/will be provided by other means at a later time. What we definitely should not do is provide the starting caps of the chain, which are potentially completely different from the end ones (like for example `application/x-rtp`) Part-of: --- subprojects/gst-plugins-base/gst/playback/gstparsebin.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/subprojects/gst-plugins-base/gst/playback/gstparsebin.c b/subprojects/gst-plugins-base/gst/playback/gstparsebin.c index 421856fd3e..7b12a3f76c 100644 --- a/subprojects/gst-plugins-base/gst/playback/gstparsebin.c +++ b/subprojects/gst-plugins-base/gst/playback/gstparsebin.c @@ -4129,10 +4129,6 @@ gst_parse_pad_stream_start_event (GstParsePad * parsepad, GstEvent * event) caps = gst_pad_get_current_caps (peer); gst_object_unref (peer); } - if (caps == NULL && parsepad->chain && parsepad->chain->start_caps) { - /* Still no caps, use the chain start caps */ - caps = gst_caps_ref (parsepad->chain->start_caps); - } GST_DEBUG_OBJECT (parsepad, "Saw stream_start with no GstStream. Adding one. Caps %"