From 3eb5d66938d958907a0e1f1a5633d7d970b7cef7 Mon Sep 17 00:00:00 2001 From: Camilo Celis Guzman Date: Mon, 18 Apr 2022 17:50:22 +0900 Subject: [PATCH] gstav1parse: fixup various possible logical errors Found via an analyzed build for Clang. Specifically we had: gstav1parse.c[1850,11] in gst_av1_parse_detect_stream_format: Logic error: The left operand of '==' is a garbage value gstav1parse.c[1606,11] in gst_av1_parse_handle_to_small_and_equal_align: Logic error: The left operand of '==' is a garbage value Also a couple of false-positives: gstav1parse.c[1398,24] in gst_av1_parse_handle_one_obu: Logic error: Branch condition evaluates to a garbage value gstav1parse.c[1440,37] in gst_av1_parse_handle_one_obu: Logic error: The left operand of '-' is a garbage value Part-of: --- subprojects/gst-plugins-bad/gst/videoparsers/gstav1parse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/subprojects/gst-plugins-bad/gst/videoparsers/gstav1parse.c b/subprojects/gst-plugins-bad/gst/videoparsers/gstav1parse.c index 980c4a0ac6..34d0a34964 100644 --- a/subprojects/gst-plugins-bad/gst/videoparsers/gstav1parse.c +++ b/subprojects/gst-plugins-bad/gst/videoparsers/gstav1parse.c @@ -1544,7 +1544,7 @@ gst_av1_parse_handle_to_small_and_equal_align (GstBaseParse * parse, GstMapInfo map_info; GstAV1OBU obu; GstFlowReturn ret = GST_FLOW_OK; - GstAV1ParserResult res; + GstAV1ParserResult res = GST_AV1_PARSER_INVALID_OPERATION; GstBuffer *buffer = gst_buffer_ref (frame->buffer); guint32 total_consumed, consumed; gboolean frame_complete; @@ -1773,7 +1773,7 @@ gst_av1_parse_detect_alignment (GstBaseParse * parse, GstAV1Parse *self = GST_AV1_PARSE (parse); GstMapInfo map_info; GstAV1OBU obu; - GstAV1ParserResult res; + GstAV1ParserResult res = GST_AV1_PARSER_INVALID_OPERATION; GstBuffer *buffer = gst_buffer_ref (frame->buffer); gboolean got_seq, got_frame; gboolean frame_complete;