mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-30 13:41:48 +00:00
Code Issues 1 Projects Releases Wiki Activity

gaudieffects: remove < 0 comparison on guint32

Browse source 
Current CLAMP checks both if the value is below 0 or above 255. Considering it
is an unsigned value it can never be less than zero, so that comparison is
unnecessary. Switching to using if just for the upper bound.

CID #1139796
This commit is contained in:
Luis de Bethencourt 2014-10-30 17:06:01 +00:00
parent 267bc774ec
commit 3e452352f0
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
gst/gaudieffects/gstsolarize.c
View file

@ -317,7 +317,7 @@ transform (guint32 * src, guint32 * dest, gint video_area,
static const guint floor = 0; static const guint floor = 0;
static const guint ceiling = 255; static const guint ceiling = 255;
gint period, up_length, down_length, height_scale, param; gint period, up_length, down_length, param;
period = end - start; period = end - start;
if (period == 0) { if (period == 0) {
@ -334,8 +334,6 @@ transform (guint32 * src, guint32 * dest, gint video_area,
down_length = 1; down_length = 1;
} }
height_scale = ceiling - floor;
/* Loop through pixels. */ /* Loop through pixels. */
for (x = 0; x < video_area; x++) { for (x = 0; x < video_area; x++) {
in = *src++; in = *src++;
@ -344,7 +342,6 @@ transform (guint32 * src, guint32 * dest, gint video_area,
color[1] = (in >> 8) & 0xff; color[1] = (in >> 8) & 0xff;
color[2] = (in) & 0xff; color[2] = (in) & 0xff;
/* Loop through colors. */ /* Loop through colors. */
for (c = 0; c < 3; c++) { for (c = 0; c < 3; c++) {
param = color[c]; param = color[c];
@ -353,20 +350,22 @@ transform (guint32 * src, guint32 * dest, gint video_area,
param %= period; param %= period;
if (param < up_length) { if (param < up_length) {
color[c] = param * height_scale; color[c] = param * ceiling;
color[c] /= up_length; color[c] /= up_length;
color[c] += floor; color[c] += floor;
} else { } else {
color[c] = down_length - (param - up_length); color[c] = down_length - (param - up_length);
color[c] *= height_scale; color[c] *= ceiling;
color[c] /= down_length; color[c] /= down_length;
color[c] += floor; color[c] += floor;
} }
} }
color[0] = CLAMP (color[0], 0, 255); /* Clamp colors */
color[1] = CLAMP (color[1], 0, 255); for (c = 0; c < 3; c++) {
color[2] = CLAMP (color[2], 0, 255); if (G_UNLIKELY (color[c] > 255))
color[c] = 255;
}
*dest++ = (color[0] << 16) | (color[1] << 8) | color[2]; *dest++ = (color[0] << 16) | (color[1] << 8) | color[2];
} }