diff --git a/ChangeLog b/ChangeLog index 7ff4bb66092..699cfc590e2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,14 @@ +2007-11-17 Stefan Kost + + * gst/gstpreset.c: + Add some comments and TODOs. + + * gst/gstpreset.h: + Add padding for future changes. + + * plugins/elements/gstqueue.c: + Implement the iface. + 2007-11-17 Stefan Kost * docs/gst/gstreamer-docs.sgml: diff --git a/gst/gstpreset.c b/gst/gstpreset.c index 6ac1bad0f3c..d4993e4eb11 100644 --- a/gst/gstpreset.c +++ b/gst/gstpreset.c @@ -36,6 +36,7 @@ * - how can we support both Preferences and Presets, a flag for _get_preset_names ? * - should there be a 'preset-list' property to get the preset list * (and to connect a notify:: to to listen for changes) + * - do we want to ship presets for some elements? * * http://www.buzztard.org/index.php/Preset_handling_interface */ diff --git a/gst/gstpreset.h b/gst/gstpreset.h index fab9babd718..08e96113ea1 100644 --- a/gst/gstpreset.h +++ b/gst/gstpreset.h @@ -61,6 +61,9 @@ struct _GstPresetInterface * instances of a type and if the list changes, we trigger the signal for all * instance */ + + /*< private >*/ + gpointer _gst_reserved[GST_PADDING]; }; GType gst_preset_get_type(void); diff --git a/plugins/elements/gstqueue.c b/plugins/elements/gstqueue.c index 5b160688a78..579d7fcc3b9 100644 --- a/plugins/elements/gstqueue.c +++ b/plugins/elements/gstqueue.c @@ -174,7 +174,15 @@ enum #define _do_init(bla) \ GST_DEBUG_CATEGORY_INIT (queue_debug, "queue", 0, "queue element"); \ GST_DEBUG_CATEGORY_INIT (queue_dataflow, "queue_dataflow", 0, \ - "dataflow inside the queue element"); + "dataflow inside the queue element"); \ + { \ + const GInterfaceInfo preset_interface_info = { \ + NULL, /* interface_init */ \ + NULL, /* interface_finalize */ \ + NULL /* interface_data */ \ + }; \ + g_type_add_interface_static(object_type, GST_TYPE_PRESET, &preset_interface_info); \ + } GST_BOILERPLATE_FULL (GstQueue, gst_queue, GstElement, GST_TYPE_ELEMENT, _do_init);