From 3a5510f61c18eec10849e52edc31f4ebbc490cd3 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Tue, 2 May 2023 11:41:41 +0200 Subject: [PATCH] srt: fix segfault if send_headers() failed The error handling code was assuming that 'internal_error' was set, while we were passing the caller GError. The internal error is already propagated to the caller later on. Part-of: --- subprojects/gst-plugins-bad/ext/srt/gstsrtobject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/gst-plugins-bad/ext/srt/gstsrtobject.c b/subprojects/gst-plugins-bad/ext/srt/gstsrtobject.c index cf6b20d86c..6c3ed6f7b7 100644 --- a/subprojects/gst-plugins-bad/ext/srt/gstsrtobject.c +++ b/subprojects/gst-plugins-bad/ext/srt/gstsrtobject.c @@ -1846,7 +1846,7 @@ gst_srt_object_write_one (GstSRTObject * srtobject, GstBufferList * headers, retry: if (!srtobject->sent_headers) { if (!gst_srt_object_send_headers (srtobject, srtobject->sock, - srtobject->poll_id, poll_timeout, headers, error)) { + srtobject->poll_id, poll_timeout, headers, &internal_error)) { goto err; }