From 39efd788a8d99d30f6a85dc70b63ab6979bb3b82 Mon Sep 17 00:00:00 2001
From: Mathieu Duponchelle <mathieu@centricular.com>
Date: Thu, 9 Nov 2023 14:22:06 +0100
Subject: [PATCH] timecodestamper: set drop-frame property default to TRUE

After talking with Vivia on IRC, she does not remember why the default
was FALSE and it is in my opinion preferable to stick to whatever
representation best represents time for a given framerate as a default
behavior.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5628>
---
 subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json | 2 +-
 subprojects/gst-plugins-bad/gst/timecode/gsttimecodestamper.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json b/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json
index 788ed92dfc..546b133913 100644
--- a/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json
+++ b/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json
@@ -236569,7 +236569,7 @@
                         "construct": false,
                         "construct-only": false,
                         "controllable": false,
-                        "default": "false",
+                        "default": "true",
                         "mutable": "null",
                         "readable": true,
                         "type": "gboolean",
diff --git a/subprojects/gst-plugins-bad/gst/timecode/gsttimecodestamper.c b/subprojects/gst-plugins-bad/gst/timecode/gsttimecodestamper.c
index f115ed7d1b..c616058de9 100644
--- a/subprojects/gst-plugins-bad/gst/timecode/gsttimecodestamper.c
+++ b/subprojects/gst-plugins-bad/gst/timecode/gsttimecodestamper.c
@@ -78,7 +78,7 @@ enum
 #define DEFAULT_SET GST_TIME_CODE_STAMPER_SET_KEEP
 #define DEFAULT_AUTO_RESYNC TRUE
 #define DEFAULT_TIMEOUT GST_CLOCK_TIME_NONE
-#define DEFAULT_DROP_FRAME FALSE
+#define DEFAULT_DROP_FRAME TRUE
 #define DEFAULT_POST_MESSAGES FALSE
 #define DEFAULT_SET_INTERNAL_TIMECODE NULL
 #define DEFAULT_LTC_DAILY_JAM NULL