From 387f533a0733de7f6b8cb6e415f09e4fb24f151e Mon Sep 17 00:00:00 2001 From: Arun Raghavan Date: Fri, 11 Mar 2011 23:06:31 +0530 Subject: [PATCH] pulsesink: Fix deadlock if connecting to PA fails Commit dd4ec22e introduced a deadlock in the failure path while trying to connect to PulseAudio. This makes sure we drop the lock on the resource mutex to avoid this. https://bugzilla.gnome.org/show_bug.cgi?id=644510 --- ext/pulse/pulsesink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ext/pulse/pulsesink.c b/ext/pulse/pulsesink.c index 6ddc490f3e..110adde3da 100644 --- a/ext/pulse/pulsesink.c +++ b/ext/pulse/pulsesink.c @@ -527,6 +527,7 @@ gst_pulseringbuffer_open_device (GstRingBuffer * buf) /* ERRORS */ unlock_and_fail: { + g_mutex_unlock (pa_shared_resource_mutex); gst_pulsering_destroy_context (pbuf); pa_threaded_mainloop_unlock (mainloop); return FALSE;