From 3738ce8ba1ba466a5029b442122ab7fd465b5933 Mon Sep 17 00:00:00 2001 From: Luis de Bethencourt Date: Mon, 8 Feb 2016 23:41:32 +0000 Subject: [PATCH] deinterlace: remove check for impossible condition Commit bd27a1f30b4458f2edee53c76dd07fb35904b61d added a few error handling memory management checks. These check srccaps to see if it needs to be unreferenced before returning, in the case of invalid_caps this goto jump always happens before srccaps is set, so it will always be NULL in this error label. CID #1352035 --- gst/deinterlace/gstdeinterlace.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/gst/deinterlace/gstdeinterlace.c b/gst/deinterlace/gstdeinterlace.c index 6b8b39d145..6d2e68c117 100644 --- a/gst/deinterlace/gstdeinterlace.c +++ b/gst/deinterlace/gstdeinterlace.c @@ -2692,8 +2692,6 @@ gst_deinterlace_setcaps (GstDeinterlace * self, GstPad * pad, GstCaps * caps) invalid_caps: { GST_ERROR_OBJECT (pad, "Invalid caps: %" GST_PTR_FORMAT, caps); - if (srccaps) - gst_caps_unref (srccaps); return FALSE; } set_caps_failed: