From 6ede81d18e7a00436faee493f42666e241ef0c19 Mon Sep 17 00:00:00 2001 From: Vincent Penquerc'h Date: Fri, 13 Jan 2012 10:43:12 +0000 Subject: [PATCH 1/5] gst-inspect: plug factory leak on error --- tools/gst-inspect.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/gst-inspect.c b/tools/gst-inspect.c index 165ad3f0b8..75e5181cb2 100644 --- a/tools/gst-inspect.c +++ b/tools/gst-inspect.c @@ -1344,6 +1344,7 @@ print_element_info (GstElementFactory * factory, gboolean print_names) element = gst_element_factory_create (factory, NULL); if (!element) { + gst_object_unref (factory); g_print ("couldn't construct element for some reason\n"); return -1; } From 4f697df84c669ad1517fd1e4e8d3b76d1896328f Mon Sep 17 00:00:00 2001 From: Mark Nauwelaerts Date: Thu, 19 Jan 2012 12:57:48 +0100 Subject: [PATCH 2/5] tests: clockstress: perform sanity check on thread number argument --- tests/benchmarks/gstclockstress.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/benchmarks/gstclockstress.c b/tests/benchmarks/gstclockstress.c index 60895d92b0..ed89840376 100644 --- a/tests/benchmarks/gstclockstress.c +++ b/tests/benchmarks/gstclockstress.c @@ -60,6 +60,11 @@ main (gint argc, gchar * argv[]) num_threads = atoi (argv[1]); + if (num_threads <= 0 || num_threads > MAX_THREADS) { + g_print ("number of threads must be between 0 and %d\n", MAX_THREADS); + exit (-2); + } + sysclock = gst_system_clock_obtain (); for (t = 0; t < num_threads; t++) { From 8accd77659d6eb99b39b31c76eff9c569b9242b6 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Tue, 17 Jan 2012 16:23:33 -0500 Subject: [PATCH 3/5] build: add --disable-fatal-warnings configure option It's reasonable to build from git, but not want to turn all compiler warnings into fatal errors. For example, GNOME's jhbuild helps people get newer versions of software than came from their distribution, but they may not necessarily want to hack on it. --- common | 2 +- configure.ac | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/common b/common index e4a9407a51..17fa4abf49 160000 --- a/common +++ b/common @@ -1 +1 @@ -Subproject commit e4a9407a51803016bab9918b03e2034981886bdb +Subproject commit 17fa4abf49d31cf5dcc2994bdbaa86e45a3fb69f diff --git a/configure.ac b/configure.ac index 7a4d05217c..90daf079b9 100644 --- a/configure.ac +++ b/configure.ac @@ -74,6 +74,8 @@ AG_GST_GETTEXT([gstreamer-$GST_MAJORMINOR]) dnl *** check for arguments to configure *** +AG_GST_ARG_DISABLE_FATAL_WARNINGS + dnl subsystems - can influence other decisions so needs to be high up dnl we need to AM_CONDITIONAL them here for automake 1.6.x compatibility AG_GST_CHECK_SUBSYSTEM_DISABLE(GST_DEBUG,[debugging subsystem]) @@ -646,7 +648,7 @@ if test "x${GST_DISABLE_GST_DEBUG}" = "xyes"; then fi dnl define an ERROR_CFLAGS Makefile variable -AG_GST_SET_ERROR_CFLAGS($GST_GIT, [-Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wformat-nonliteral -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Waggregate-return -Wno-multichar -Wnested-externs $NO_WARNINGS]) +AG_GST_SET_ERROR_CFLAGS($FATAL_WARNINGS, [-Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wformat-nonliteral -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Waggregate-return -Wno-multichar -Wnested-externs $NO_WARNINGS]) dnl define correct level for debugging messages AG_GST_SET_LEVEL_DEFAULT($GST_GIT) From 28d5e8150369efb477a25a4e701e62281fbecebc Mon Sep 17 00:00:00 2001 From: Vincent Penquerc'h Date: Fri, 20 Jan 2012 18:06:04 +0000 Subject: [PATCH 4/5] libcheck: make the definition of fail not fail with non GCC compilers --- libs/gst/check/libcheck/check.h.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/gst/check/libcheck/check.h.in b/libs/gst/check/libcheck/check.h.in index 231fdbb568..3ed1acd75d 100644 --- a/libs/gst/check/libcheck/check.h.in +++ b/libs/gst/check/libcheck/check.h.in @@ -232,7 +232,7 @@ static void __testname (int _i CK_ATTRIBUTE_UNUSED)\ "Failure '"#expr"' occured" , ## __VA_ARGS__, NULL) /* Always fail */ -#define fail(...) _fail_unless(0, __FILE__, __LINE__, "Failed" , ## __VA_ARGS__, NULL) +#define fail(...) _fail_unless(0, __FILE__, __LINE__, "Failed" __VA_ARGS__, NULL) /* Non macro version of #fail_unless, with more complicated interface */ void CK_EXPORT _fail_unless (int result, const char *file, From e1dbab9bea550f4f61c792ed92acc3bd687d43d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Sat, 21 Jan 2012 12:56:50 +0000 Subject: [PATCH 5/5] scripts: set GI_TYPELIB_PATH in gst-uninstalled So pygi finds/uses the local g-i files. --- scripts/gst-uninstalled | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scripts/gst-uninstalled b/scripts/gst-uninstalled index 485a1c16a0..045c43757f 100755 --- a/scripts/gst-uninstalled +++ b/scripts/gst-uninstalled @@ -59,10 +59,12 @@ $PATH" # /some/path: makes the dynamic linker look in . too, so avoid this LD_LIBRARY_PATH=$GST_PREFIX/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH} DYLD_LIBRARY_PATH=$GST_PREFIX/lib${DYLD_LIBRARY_PATH:+:$DYLD_LIBRARY_PATH} +GI_TYPELIB_PATH=$GST_PREFIX/share/gir-1.0${GI_TYPELIB_PATH:+:$GI_TYPELIB_PATH} # GStreamer rtsp server library LD_LIBRARY_PATH=$GST/gst-rtsp-server/gst/rtsp-server/.libs:$LD_LIBRARY_PATH DYLD_LIBRARY_PATH=$GST/gst-rtsp-server/gst/rtsp-server/.libs:$DYLD_LIBRARY_PATH +GI_TYPELIB_PATH=$GST/gst-rtsp-server/gst/rtsp-server:$GI_TYPELIB_PATH # GStreamer ffmpeg libraries for path in libavformat libavutil libavcodec libpostproc libavdevice @@ -76,6 +78,7 @@ for path in app audio cdda fft interfaces pbutils netbuffer riff rtp rtsp sdp ta do LD_LIBRARY_PATH=$GST/gst-plugins-base/gst-libs/gst/$path/.libs:$LD_LIBRARY_PATH DYLD_LIBRARY_PATH=$GST/gst-plugins-base/gst-libs/gst/$path/.libs:$DYLD_LIBRARY_PATH + GI_TYPELIB_PATH=$GST/gst-plugins-base/gst-libs/gst/$path:$GI_TYPELIB_PATH done # GStreamer core libraries @@ -83,11 +86,14 @@ for path in base net check controller dataprotocol do LD_LIBRARY_PATH=$GST/gstreamer/libs/gst/$path/.libs:$LD_LIBRARY_PATH DYLD_LIBRARY_PATH=$GST/gstreamer/libs/gst/$path/.libs:$DYLD_LIBRARY_PATH + GI_TYPELIB_PATH=$GST/gstreamer/libs/gst/$path:$GI_TYPELIB_PATH done LD_LIBRARY_PATH=$GST/gstreamer/gst/.libs:$LD_LIBRARY_PATH DYLD_LIBRARY_PATH=$GST/gstreamer/gst/.libs:$DYLD_LIBRARY_PATH +GI_TYPELIB_PATH=$GST/gstreamer/gst:$GI_TYPELIB_PATH export LD_LIBRARY_PATH export DYLD_LIBRARY_PATH +export GI_TYPELIB_PATH export PKG_CONFIG_PATH="\ $GST_PREFIX/lib/pkgconfig\