From 35271a2ef3ee3ce38dc2f442f0619ed0bffd90c6 Mon Sep 17 00:00:00 2001 From: "L. E. Segovia" Date: Tue, 19 Mar 2024 20:04:15 -0300 Subject: [PATCH] isac: Work around upstream having no shared library support for MSVC None of the symbols in webrtc-audio-coding-1 are marked with `__declspec(dllexport)`, rendering the library usable only if it was built with GCC/Clang. The only fix available (as the pulseaudio copy has not been updated with Google's upstream) is to ensure the fallback builds statically. Although this change will also affect webrtcdsp's dependency on webrtc-audio-processing-1, it does not break its compilation. Part-of: --- subprojects/gst-plugins-bad/ext/isac/meson.build | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/subprojects/gst-plugins-bad/ext/isac/meson.build b/subprojects/gst-plugins-bad/ext/isac/meson.build index eb1e38cdd5..68e9e4f5fe 100644 --- a/subprojects/gst-plugins-bad/ext/isac/meson.build +++ b/subprojects/gst-plugins-bad/ext/isac/meson.build @@ -1,4 +1,9 @@ -webrtc_audio_coding_dep = dependency('webrtc-audio-coding-1', required: get_option('isac')) +if cc.get_define('_MSC_VER') != '' + webrtc_audio_coding_dep = dependency('webrtc-audio-coding-1', required: get_option('isac'), default_options: ['default_library=static']) +else + webrtc_audio_coding_dep = dependency('webrtc-audio-coding-1', required: get_option('isac')) +endif + if webrtc_audio_coding_dep.found() isac_sources = [