From 34deb5b70313128065c4403d479b0af2637aaaf8 Mon Sep 17 00:00:00 2001 From: Vincent Penquerc'h Date: Fri, 18 May 2012 12:46:55 +0100 Subject: [PATCH] vp8enc: fix target bitrate config with libvpx 1.1.0 libvpx 1.1.0 disallows a bitrate of 0, which was used by vp8enc as a default value. Instead, we use the default libvpx bitrate, scaled to our video size, if no bitrate was specified. This fixes encoding VP8 video with libvpx 1.1.0. https://bugzilla.gnome.org/show_bug.cgi?id=676245 --- ext/vp8/gstvp8enc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ext/vp8/gstvp8enc.c b/ext/vp8/gstvp8enc.c index 9b0c4fe3ef..6316021779 100644 --- a/ext/vp8/gstvp8enc.c +++ b/ext/vp8/gstvp8enc.c @@ -734,6 +734,11 @@ gst_vp8_enc_set_format (GstVideoEncoder * video_encoder, return FALSE; } + /* Scale default bitrate to our size */ + cfg.rc_target_bitrate = gst_util_uint64_scale (cfg.rc_target_bitrate, + GST_VIDEO_INFO_WIDTH (info) * GST_VIDEO_INFO_HEIGHT (info), + cfg.g_w * cfg.g_h); + cfg.g_w = GST_VIDEO_INFO_WIDTH (info); cfg.g_h = GST_VIDEO_INFO_HEIGHT (info); cfg.g_timebase.num = GST_VIDEO_INFO_FPS_D (info); @@ -757,7 +762,6 @@ gst_vp8_enc_set_format (GstVideoEncoder * video_encoder, } else { cfg.rc_min_quantizer = (gint) (63 - encoder->quality * 6.2); cfg.rc_max_quantizer = (gint) (63 - encoder->quality * 6.2); - cfg.rc_target_bitrate = encoder->bitrate; } cfg.rc_dropframe_thresh = encoder->drop_frame; cfg.rc_resize_allowed = encoder->resize_allowed;