From 34a124590506f896eb89a676364d1084fc1f66ff Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Tue, 20 Feb 2024 16:00:07 +0100 Subject: [PATCH] subparsers: Give proper category to subtitle "decoders" Some subtitle "decoders" had a wrong category of "Parser", which `parsebin` relies on to identify elements which do not *decode* streams but *parse* them. This would cause such subtitle decoders to be plugged in within parsebin, preventing the original stream to be properly used by (more efficient) downstream decoders or subtitle renderers. Fixes #1757 Part-of: --- .../gst-plugins-bad/docs/plugins/gst_plugins_cache.json | 2 +- subprojects/gst-plugins-bad/ext/ttml/gstttmlparse.c | 2 +- .../gst-plugins-base/docs/plugins/gst_plugins_cache.json | 4 ++-- subprojects/gst-plugins-base/gst/subparse/gstssaparse.c | 2 +- subprojects/gst-plugins-base/gst/subparse/gstsubparse.c | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json b/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json index bcf4df8cf5..022454cac5 100644 --- a/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json +++ b/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json @@ -241374,7 +241374,7 @@ "GInitiallyUnowned", "GObject" ], - "klass": "Codec/Parser/Subtitle", + "klass": "Codec/Decoder/Subtitle", "long-name": "TTML subtitle parser", "pad-templates": { "sink": { diff --git a/subprojects/gst-plugins-bad/ext/ttml/gstttmlparse.c b/subprojects/gst-plugins-bad/ext/ttml/gstttmlparse.c index eafa7193f8..649a041699 100644 --- a/subprojects/gst-plugins-bad/ext/ttml/gstttmlparse.c +++ b/subprojects/gst-plugins-bad/ext/ttml/gstttmlparse.c @@ -129,7 +129,7 @@ gst_ttml_parse_class_init (GstTtmlParseClass * klass) gst_element_class_add_pad_template (element_class, gst_static_pad_template_get (&src_templ)); gst_element_class_set_static_metadata (element_class, - "TTML subtitle parser", "Codec/Parser/Subtitle", + "TTML subtitle parser", "Codec/Decoder/Subtitle", "Parses TTML subtitle files", "GStreamer maintainers , " "Chris Bass "); diff --git a/subprojects/gst-plugins-base/docs/plugins/gst_plugins_cache.json b/subprojects/gst-plugins-base/docs/plugins/gst_plugins_cache.json index 12a764e284..571c004911 100644 --- a/subprojects/gst-plugins-base/docs/plugins/gst_plugins_cache.json +++ b/subprojects/gst-plugins-base/docs/plugins/gst_plugins_cache.json @@ -13010,7 +13010,7 @@ "GInitiallyUnowned", "GObject" ], - "klass": "Codec/Parser/Subtitle", + "klass": "Codec/Decoder/Subtitle", "long-name": "SSA Subtitle Parser", "pad-templates": { "sink": { @@ -13036,7 +13036,7 @@ "GInitiallyUnowned", "GObject" ], - "klass": "Codec/Parser/Subtitle", + "klass": "Codec/Decoder/Subtitle", "long-name": "Subtitle parser", "pad-templates": { "sink": { diff --git a/subprojects/gst-plugins-base/gst/subparse/gstssaparse.c b/subprojects/gst-plugins-base/gst/subparse/gstssaparse.c index d6fdb9c9fc..42fbb42b99 100644 --- a/subprojects/gst-plugins-base/gst/subparse/gstssaparse.c +++ b/subprojects/gst-plugins-base/gst/subparse/gstssaparse.c @@ -108,7 +108,7 @@ gst_ssa_parse_class_init (GstSsaParseClass * klass) gst_element_class_add_static_pad_template (element_class, &sink_templ); gst_element_class_add_static_pad_template (element_class, &src_templ); gst_element_class_set_static_metadata (element_class, - "SSA Subtitle Parser", "Codec/Parser/Subtitle", + "SSA Subtitle Parser", "Codec/Decoder/Subtitle", "Parses SSA subtitle streams", "Tim-Philipp Müller "); diff --git a/subprojects/gst-plugins-base/gst/subparse/gstsubparse.c b/subprojects/gst-plugins-base/gst/subparse/gstsubparse.c index 2b69595e5c..994cf62d1a 100644 --- a/subprojects/gst-plugins-base/gst/subparse/gstsubparse.c +++ b/subprojects/gst-plugins-base/gst/subparse/gstsubparse.c @@ -137,7 +137,7 @@ gst_sub_parse_class_init (GstSubParseClass * klass) gst_element_class_add_static_pad_template (element_class, &sink_templ); gst_element_class_add_static_pad_template (element_class, &src_templ); gst_element_class_set_static_metadata (element_class, - "Subtitle parser", "Codec/Parser/Subtitle", + "Subtitle parser", "Codec/Decoder/Subtitle", "Parses subtitle (.sub) files into text streams", "Gustavo J. A. M. Carneiro , " "GStreamer maintainers ");